Re: [patch/backport] CFS scheduler, -v24, for v2.6.24-rc3, v2.6.23.8,v2.6.22.13, v2.6.21.7

From: David
Date: Mon Nov 19 2007 - 14:52:20 EST


El Lunes, 19 de Noviembre de 2007, Ingo Molnar escribió:
> * David <david@xxxxxxxxx> wrote:
> > Hi Ingo,
> >
> > Thnx a lot for theses backports...
> >
> > Ran into this while compiling a 2.6.23.8 with CFS v24
> >
> > Compiling with CONFIG_FAIR_GROUP_SCHED disabled :
> >
> > kernel/sysctl.c:305: error: 'sysctl_sched_min_bal_int_shares' undeclared
> > here (not in a function) kernel/sysctl.c:313: error:
> > 'sysctl_sched_max_bal_int_shares' undeclared here (not in a function)
> >
> > I made that patch to make it compile.
>
> thanks - i've applied your fix and have re-uploaded under the same
> filenames - so if anyone hits this problem it can be fixed by
> re-downloading the same patch again. Find below the current set of -v24
> build fixlets.
>
> Ingo
>
> --- linux.orig/kernel/sysctl.c
> +++ linux/kernel/sysctl.c
> @@ -309,6 +309,7 @@ static struct ctl_table kern_table[] = {
> .mode = 644,
> .proc_handler = &proc_dointvec,
> },
> +#ifdef CONFIG_FAIR_GROUP_SCHED
> {
> .ctl_name = CTL_UNNUMBERED,
> .procname = "sched_min_bal_int_shares",
> @@ -326,6 +327,7 @@ static struct ctl_table kern_table[] = {
> .proc_handler = &proc_dointvec,
> },
> #endif
> +#endif
> {
> .ctl_name = CTL_UNNUMBERED,
> .procname = "sched_compat_yield",
> --- linux.orig/include/linux/sched.h
> +++ linux/include/linux/sched.h
> @@ -10,7 +10,7 @@
> #define COMPAT_REGISTER_SYSCTL
>
> /* backporting helper macro: */
> -#define cpu_sibling_map(cpu) per_cpu(cpu_sibling_map, cpu)
> +#define cpu_sibling_map(cpu) cpu_sibling_map[cpu]
>
> /*
> * cloning flags:

I have removed all other patches, and applied only cfs v24 above 2.6.23.8, and
the compiler ran into (with CONFIG_FAIR_GROUP_SCHED enabled):

CC kernel/sched.o
kernel/sched.c: In function 'rebalance_shares':
kernel/sched.c:7021: error: dereferencing pointer to incomplete type
kernel/sched.c: In function 'load_balance_monitor':
kernel/sched.c:7107: error: 'ndoms_cur' undeclared (first use in this
function)
kernel/sched.c:7107: error: (Each undeclared identifier is reported only once
kernel/sched.c:7107: error: for each function it appears in.)
kernel/sched.c:7108: error: 'doms_cur' undeclared (first use in this function)
kernel/sched.c:7114: error: 'struct rq' has no member named 'sd'
kernel/sched.c:7114: warning: type defaults to 'int' in declaration
of '_________p1'
kernel/sched.c:7114: error: 'struct rq' has no member named 'sd'
kernel/sched.c:7114: warning: assignment makes pointer from integer without a
cast
kernel/sched.c:7114: error: dereferencing pointer to incomplete type
kernel/sched.c:7115: error: dereferencing pointer to incomplete type
kernel/sched.c:7115: error: 'SD_LOAD_BALANCE' undeclared (first use in this
function)
kernel/sched.c:7108: warning: unused variable 'cpumap'
make[1]: *** [kernel/sched.o] Error 1

I can send my config if needed

--
David Rodríguez García
Director Técnico
LiVux I+D S.L.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/