Re: [PATCH] Fix segfault when printing battery status

From: Alexey Starikovskiy
Date: Mon Nov 19 2007 - 06:09:35 EST


Rolf Eike Beer wrote:
Alexey Starikovskiy wrote:
Rolf Eike Beer wrote:
cat
/sys/devices/LNXSYSTM:00/device:00/PNP0A08:00/device:19/PNP0C0A:00/power_
supply/BAT1/status

This leads to a stacktrace as acpi_battery_get_property() returns 0 for a
case where it does not set val->intval. These value is used as an array
index in
drivers/power/power_supply_sysfs.c::power_supply_show_property(). I had a
situation where the value was 4096 which caused a problem as the array
only has 5 entries.

Signed-off-by: Rolf Eike Beer <eike-kernel@xxxxxxxxx>
Rolf, thanks for remainding.

Huh? This one is unrelated to the problem I reported two weeks ago...

Eike
You are second to send the same patch, first one I already acked.
But it seems that Len did not pick it up yet.
Look for "ACPI: Always return valid 'status' from acpi_battery_get_property()"
if interested...

Regards,
Alex.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/