Re: apm emulation driver broken ?
From: Franck Bui-Huu
Date: Sat Nov 17 2007 - 03:54:04 EST
Rafael J. Wysocki wrote:
> However, using PF_NOFREEZE to prevent this from happening doesn't seem to be
> a good idea.
>
Indeed but...
> I'd probably use wait_event_freezable() (defined in
> include/linux/freezer.h) for that.
...I would just revert this bits from now to make sure this driver
work again for v2.6.24.
> It tries to send them fake signals and waits for them to freeze. If
> they don't freeze within the timeout, it fails and clears their
> TIF_FREEZE bits.
But send_fake_signal() seems to wake up task in INTERRUPTIBLE state
only. Looking at signal_wake_up(), it basically do:
wake_up_state(t, TASK_INTERRUPTIBLE);
What am I missing ?
Franck
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/