Re: [PATCH 2/3] mmap: round mmap hint address above mmap_min_addr

[James Morris]

On Fri, 16 Nov 2007, Eric Paris wrote:

> On Sat, 2007-11-17 at 08:42 +1100, James Morris wrote:
> > On Fri, 16 Nov 2007, Eric Paris wrote:
> > 
> > > +#ifdef CONFIG_SECURITY
> > > +	/*
> > > +	 * If a hint addr is less than mmap_min_addr change addr to be as
> > > +	 * low as possible but still greater than mmap_min_addr
> > > +	 */
> > > +	if (!(flags & MAP_FIXED) && ((void *)addr != NULL) &&
> > > +	    (addr < mmap_min_addr))
> > > +		addr = PAGE_ALIGN(mmap_min_addr);
> > > +#endif
> > 
> > Please make this a static inline which is optimized away with 
> > !CONFIG_SECURITY.
> 
> Where do you think these should go?  You think I should instead have a
> static inline function in both mmap.c and nommu.c so the CONFIG check
> isn't scattered in this code but still in this file?  Or did you
> actually want something in security.h so I only have the code once?

Both: not having #ifdefs in the core kernel code (we had pushback on this 
when LSM was being developed), and consolidating the code.  It doesn't 
actually call into LSM modules, so may be better to put it in 
include/linux/mm.h.


- James
-- 
James Morris
<jmorris@xxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/