Re: [patch 3/6] sclp: call sclp_init() from start_kernel().

From: Bastian Blank
Date: Fri Nov 16 2007 - 10:44:39 EST


On Fri, Nov 16, 2007 at 03:29:45PM +0100, Martin Schwidefsky wrote:
> #else
> static inline void acpi_early_init(void) { }
> #endif
> +#ifdef CONFIG_S390
> +extern int sclp_init(void);
> +#else
> +static inline int sclp_init(void) {return 0;}
> +#endif
> #ifndef CONFIG_DEBUG_RODATA
> static inline void mark_rodata_ro(void) { }
> #endif
> @@ -643,6 +648,7 @@ asmlinkage void __init start_kernel(void
> check_bugs();
>
> acpi_early_init(); /* before LAPIC and SMP init */
> + sclp_init();

What happens if sclp_init fails? The other early init calls explicitely
returns void and handels the error internal.

Bastian

--
Time is fluid ... like a river with currents, eddies, backwash.
-- Spock, "The City on the Edge of Forever", stardate 3134.0
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/