Re: 2.6.24-rc2-mm1

[Torsten Kaiser]

On Nov 15, 2007 10:34 PM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, 15 Nov 2007 22:24:12 +0100
> "Torsten Kaiser" <just.for.lkml@xxxxxxxxxxxxxx> wrote:
>
> > The problem with the first bisect-try was, that everything between
> > bisect-good: r-o-bind-mounts-elevate-write-count-over-calls-to-vfs_rename
> > and
> > bisect-bad: use-struct-path-in-struct-svc_export
> > did not compile like this:
> >
> >   CC [M]  fs/nfsd/vfs.o
> > fs/nfsd/vfs.c: In function 'nfsd_rename':
> > fs/nfsd/vfs.c:1695: error: request for member 'mnt' in something not a
> > structure or union
>
> argh.  I'd incorrectly worked out that
> nfsd-fix-wrong-mnt_writer-count-in-rename.patch was a fix against
> r-o-bind-mounts-elevate-write-count-over-calls-to-vfs_rename.patch however
> it is in fact a fix against use-struct-path-in-struct-svc_export.patch.
>
> My life sucks.
>

I think the placement was correct, but the patch itself was made
against a tree that already contained the changes from
use-struct-path-in-struct-svc_export.patch.
nfsd-fix-wrong-mnt_writer-count-in-rename.patch should have used the
old naming ex_mnt and only use-struct-path-in-struct-svc_export.patch
should have changed it to ex_path.mnt.

Torsten
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/