Re: [PATCH 2/5] Construct one fakephp slot per pci slot

[Rolf Eike Beer]

Am Mittwoch, 14. November 2007 schrieb Alex Chiang:
> * Matthew Wilcox <matthew@xxxxxx>:
> > On Wed, Nov 14, 2007 at 12:37:29PM -0700, Alex Chiang wrote:
> > > Register one slot per slot, rather than one slot per function.
> > > Change the name of the slot to fake%d instead of the pci address.
> > >
> > > +#define SLOT_NAME_SIZE KOBJ_NAME_LEN
> >
> > Defined, then never used ... how about s/KOBJ_NAME_LEN/8/, then use
> > SLOT_NAME_SIZE throughout?
>
> Whoops, good catch. I had a braino there.

Just drop it and use sizeof(dslot->name) in snprintf(). Just be careful not to 
use slot->name there as it would always be sizeof(void*)!

Eike

Attachment: signature.asc
Description: This is a digitally signed message part.