Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

From: Ingo Molnar
Date: Sun Nov 11 2007 - 09:20:56 EST



* Erez Zadok <ezk@xxxxxxxxxxxxx> wrote:

> Small patch below fixes compile error.

> + char name[sizeof(current->comm)];
> warned++;
> printk(KERN_INFO
> "warning: process `%s' sets w/ old libcap\n",
> - get_task_comm(current));
> + get_task_comm(name, current));

that's buggy - get_task_comm() returns void.

the proper fix would be to first do a get_task_comm() then pass in
'name' as an argument to printk.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/