Re: [PATCH 1/2] create file_drop_write_access() helper

[Erez Zadok]

In message <20071109210439.122065A3@kernel>, Dave Hansen writes:
> 
> These should fix the bug that Erez Zadok <ezk@xxxxxxxxxxxxx>
> reported:
> 
> Stopping RPC idmapd:
> 
> kernel: __fput() of writeable file with no mnt_want_write()
> kernel: WARNING: at fs/file_table.c:262 __fput()
> kernel:  [<c010283e>] show_trace_log_lvl+0x12/0x25
> kernel:  [<c0103042>] show_trace+0xd/0x10
> ...
> 
> The actual bug was a missed mnt_want_write() when a
> filp was allocated with get_empty_filp() and then
> made writable.  Using alloc_file(), instead, fixes
> that.
[...]

I can confirm that this patch fixes the bug I reported earlier today.

Thanks,
Erez.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/