Re: [PATCH] pktcdvd: fix BUG caused by sysfs module reference semanticschange

From: Tejun Heo
Date: Thu Nov 08 2007 - 01:56:18 EST


Greg KH wrote:
> On Thu, Nov 08, 2007 at 11:27:16AM +0900, Tejun Heo wrote:
>> pkt_setup_dev() expects module reference to be held on invocation.
>> This used to be true for sysfs callbacks but not anymore. Test and
>> grab module reference around pkt_setup_dev() in
>> class_pktcdvd_store_add().
>>
>> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
>> Acked-by: Peter Osterlund <petero2@xxxxxxxxx>
>> ---
>> Greg, can you please push this patch through your tree?
>> Thanks a lot.
>>
>> drivers/block/pktcdvd.c | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>
> Why through my tree? I don't do block devices :)

Because it's a regression introduced by changes in sysfs?

> Shouldn't Jens or at least Andrew take it?

That's fine too. Jens?

--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/