Re: [linux-usb-devel] [PATCH 1/2] usb_gigaset: suspend support

[Alan Stern]

On Mon, 29 Oct 2007, Tilman Schmidt wrote:

> From: Tilman Schmidt <tilman@xxxxxxx>
> 
> Add basic suspend/resume support to the usb_gigaset driver.

> @@ -117,6 +122,11 @@ static struct usb_driver gigaset_usb_dri
>  	.probe =	gigaset_probe,
>  	.disconnect =	gigaset_disconnect,
>  	.id_table =	gigaset_table,
> +	.suspend =	gigaset_suspend,
> +	.resume =	gigaset_resume,
> +	.reset_resume =	gigaset_resume,
> +	.pre_reset =	gigaset_suspend,
> +	.post_reset =	gigaset_resume,
>  };

Does this really compile?  The .pre_reset and .suspend members are 
pointers to functions with different prototypes; I don't see how you 
can assign the same function to both pointers.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/