Re: [build bug, 2.6.24-rc1] CONFIG_VIDEO_DEV=m &CONFIG_VIDEO_SAA7146_VV=y

[Ingo Molnar]

* Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:

> > config VIDEO_SAA7146_VV
> > 	tristate
> > 	depends on VIDEO_DEV = y || VIDEO_DEV = VIDEO_SAA7146_VV
> > 	select VIDEOBUF_DMA_SG
> > 	select VIDEO_SAA7146
> > 
> > (untested)
> 
> Nope, won't work.  I tried that last night.  VIDEO_DEV_SAA7146_VV
> has too many "select"s involved, but select doesn't follow the dependency
> chains.  IOW, as written in Documentation/kbuild/kconfig-language.txt:
> 
> 	select is evil.... select will by brute force set a symbol
> 	equal to 'y' without visiting the dependencies. So abusing
> 	select you are able to select a symbol FOO even if FOO depends
> 	on BAR that is not set.

so ... what should we do? Remove those ~7 select VIDEO_SAA7146_VV lines 
and replace them with depends on VIDEO_SAA7146_VV ?

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/