Re: linux-2.6.23-git3: Many sysfs-related warnings in dmesg

From: Kay Sievers
Date: Sat Oct 27 2007 - 02:06:36 EST


On Fri, 2007-10-26 at 19:36 -0700, Greg KH wrote:
> On Fri, Oct 26, 2007 at 08:07:44PM +0200, Kay Sievers wrote:
> > On Fri, 2007-10-26 at 12:05 -0500, Larry Finger wrote:
> > > On my openSUSE 10.3 x86_64 system running v2.6.24-rc1-281-g22d2aa1,
> > > I get the sysfs rename messages.
> >
> > Care to try this? Seems like a silly bug in the core if
> > SYSFS_DEPRECATED=y. That's why we didn't catch this earlier, sorry.

> > From: Kay Sievers <kay.sievers@xxxxxxxx>
> > Subject: Driver Core: fix bug in device_rename() for SYSFS_DEPRECATED=y
> >
>
> Do you have some more information for the change log here? Are we just
> not unwinding from errors properly?

The code just shouldn't run if class devices are real directories, it's
an update for the symlink in the class directory. Nobody noticed that as
long as the creation of sysfs files silently failed, and we both missed
it before the merge, because we don't run SYSFS_DEPRECATED=y.

Kay

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/