Re: [2.6 patch] always export sysctl_{r,w}mem_max

[Rick Jones]

Eric W. Biederman wrote:
> Adrian Bunk <bunk@xxxxxxxxxx> writes:
>
>
> > This patch fixes the following build error with CONFIG_SYSCTL=n:
> >
> > <--  snip  -->
> >
> > ...
> > ERROR: "sysctl_rmem_max" [fs/dlm/dlm.ko] undefined!
> > ERROR: "sysctl_wmem_max" [drivers/net/rrunner.ko] undefined!
> > ERROR: "sysctl_rmem_max" [drivers/net/rrunner.ko] undefined!
> > make[2]: *** [__modpost] Error 1
>
>
> I was going to ask if allowing drivers to increase rmem_max
> is something that we want to do.  Apparently the road runner
> driver has been doing this since the 2.6.12-rc1 when the
> git repository starts so this probably isn't a latent bug.

Although it does rather sound like a driver writer yanking the rope from the 
hand's of the sysadmin and hanging him with it rather than letting the sysadmin 
do it himself.  I've seen other drivers' README's suggesting larger mem's but 
not their sources doing it.

rick jones

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/