Re: [PATCH 5/6] x86: move i386 and x86_64 Kconfig files to x86 directory

From: Yinghai Lu
Date: Fri Oct 26 2007 - 01:52:15 EST


On 10/25/07, Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
> On Thu, 25 Oct 2007 18:53:18 -0700 Yinghai Lu wrote:
>
> > On 10/25/07, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> > > From 6654a98eb8587f0538904c9bdb9aeaf9d577f182 Mon Sep 17 00:00:00 2001
> > > From: Sam Ravnborg <sam@xxxxxxxxxxxx>
> > > Date: Thu, 25 Oct 2007 21:04:16 +0200
> > > Subject: [PATCH] x86: move i386 and x86_64 Kconfig files to x86 directory
> > >
> > > After a small change in kconfig Makefile we could
> > > move all x86 Kconfig files to x86 directory.
> > >
> > > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> > > ---
> > > arch/{i386 => x86}/Kconfig.cpu | 0
> > > arch/{i386 => x86}/Kconfig.debug | 0
> > > arch/{i386/Kconfig => x86/Kconfig.i386} | 4 +-
> > > arch/{x86_64/Kconfig => x86/Kconfig.x86_64} | 2 +-
> > > arch/x86_64/Kconfig.debug | 119 ---------------------------
> > > scripts/kconfig/Makefile | 7 ++-
> > > 6 files changed, 9 insertions(+), 123 deletions(-)
> > > rename arch/{i386 => x86}/Kconfig.cpu (100%)
> > > rename arch/{i386 => x86}/Kconfig.debug (100%)
> > > rename arch/{i386/Kconfig => x86/Kconfig.i386} (99%)
> > > rename arch/{x86_64/Kconfig => x86/Kconfig.x86_64} (99%) <------<
> > > delete mode 100644 arch/x86_64/Kconfig.debug |
> > |
> > arch/i386/Kconfig.debug will be arch/x86/Kconfig.debug |
> > |
> > in it, EARLY_PRINTK will depend on X86_32 |
> |
> but EARLY_PRINTK for x86_64 is here ------------------------------- ^
>
> so we didn't lose it. However, they should live in the same place
> so that confusion like this does not continue.
>
> You can make a patch. or I can. or Sam can. or someone else can...

in PATCH 3/5 that Sam sent out.