Re: [2.6 patch] #if 0 cpufreq.c:cpufreq_get()

From: Russell King
Date: Wed Oct 24 2007 - 13:29:10 EST


On Wed, Oct 24, 2007 at 09:38:39AM -0700, Arjan van de Ven wrote:
> On Wed, 24 Oct 2007 18:23:12 +0200
> Adrian Bunk <bunk@xxxxxxxxxx> wrote:
>
> > cpufreq.c:cpufreq_get() no longer has any user.
> >
>
> it's... also a really bad/buggy interface... frquency is a per cpu
> property for one, and constantly changing (esp in a multi-core world)
> even depending on what other parts of the system are doing.

... and such an assumption which would make it impossible to use
the LCD controller on StrongARM-11x0 processors.

This is precisely why we have CPUFREQ - so that hardware which needs
to be re-timed when the CPU frequency changes can get notified of that
event and take the appropriate action. It exists. It works.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/