Re: [PATCH 1/4] stringbuf: A string buffer implementation

From: Linus Torvalds
Date: Tue Oct 23 2007 - 19:44:13 EST




On Tue, 23 Oct 2007, Matthew Wilcox wrote:
>
> This is a generic string buffer which can also be used for non-printk
> purposes. There is no sb_scanf implementation yet as I haven't identified
> a user for it.

Hmm. Have you looked at the git "strbuf" code?

And stuff like "sb_string()" are just evil. The string is there. Just call
it something better than "s", and let people just use "sb->buf" or
something. Why make the interface harder to use than necessary?

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/