Re: [PATCH 09/10] Change table chaining layout

From: Andi Kleen
Date: Tue Oct 23 2007 - 15:56:56 EST


Jens Axboe <jens.axboe@xxxxxxxxxx> writes:

>> You might want to put a BUG_ON(page & 0x3); Make sure
>> you're not loosing information. (The m68k problem)
>
> That's a really good idea, thanks Boaz! I'll add that.

It would be even better if you replaced all the magic numbers with defines
or better accessors.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/