Re: [PATCH 1/2] irq_flags_t: intro and core annotations

[Thomas Gleixner]

On Mon, 22 Oct 2007, Arnd Bergmann wrote:

> On Monday 22 October 2007, Andrew Morton wrote:
> > It's almost always a bug to do spin_lock_irq() when local interrupts are
> > disabled. Â However iirc when we've tried to add runtime debugging to catch
> > that, it triggered false-positives which made the idea unworkable. Â I forget
> > where.
> 
> I tried this as well a few years ago, and I think I hit a few places in
> the early initialization, but nothing unfixable.

Hmm, lockdep checks this already. If it does not catch it, we need to fix it.

     tglx