Re: [uml-devel] User Mode Linux still doesn't build in2.6.23-final.

[Ingo Molnar]

* Al Viro <viro@xxxxxxxxxxxxxxxx> wrote:

> in kernel/sched.c
> 
> FWIW, I would simply kill the damn fastcall thing - right now the only 
> user is uml/i386; everything else either has it #defined to nothing or 
> (as i386 does) passes -mregparm=3 while having fastcall expand to 
> __attribute__((regparm(3))) - i.e. has all functions fastcall.
> 
> Do we really need it on uml/i386 enough to keep bothering with that 
> mess?

we should kill it there too.

the only place where we should _please_ keep those annotations are for 
functions that get called from assembly code. This makes life immensely 
easier for -pg (CONFIG_FUNCTION_TRACING) kernels.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/