Re: [PATCH 00/11] KVM updates for Linux 2.6.24-rc review

From: Avi Kivity
Date: Sun Oct 21 2007 - 08:12:32 EST


Laurent Vivier wrote:
Avi Kivity a écrit :
Avi Kivity wrote:
The following patches fix fallout from the main 2.6.24 KVM merge. An
exception is the movnti emulation patch, which adds support for Linux
2.6.16 guests.

The patches can be found in kvm.git in the branch kvm-updates-2.6.24.
There is also a branch kvm-updates-2.6.25 which will form the basis of
the next merge window submission.

Please review the patches and let me know if something is wrong or if
a patch is missing.



Laurent, I believe the following patch (in kvm-updates-2.6.25) needs to go into 2.6.24 as well. Can you comment on this?

What kind of comment do you want ?

Well, whether it needs to go into .24.

What are the requirements to go in 2.6.24 instead of 2.6.25 ?

Is a bug correction enough ? :-P


It has to fix something real-life, in a real guest.

This patch correct a bad behavior of x86_emulate_insn() in case of error with a REP prefix.

This patch is needed because, without it, when REP prefix is used with an instruction failing for some reasons (like IO or page fault) we don't restore all modified registers (like RSI and RDI), but only ECX and EIP, so when we re-enter in x86_emulate_insn() we modify again an already modified value. Moreover, this patch manages correctly the case where the instruction fails in writeback().


Okay, I guess it is needed. Can you backport it to the branch? It's very different from kvm-updates-2.6.24...

--
error compiling committee.c: too many arguments to function

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/