Re: [PATCH 6/17] drivers/char/riscom8: irq handler cleanups

From: Jiri Slaby
Date: Sun Oct 21 2007 - 05:01:55 EST


On 10/21/2007 09:52 AM, Jeff Garzik wrote:
> commit 93ea6d56f83b7b614c103222fa098cb30d26f608
> Author: Jeff Garzik <jeff@xxxxxxxxxx>
> Date: Fri Oct 19 16:41:23 2007 -0400
>
> drivers/char/riscom8: irq handler cleanups
>
> No need to lookup board ptr, we already have it.
>
> Also, remove a few 'inline' markers and let the compiler make that
> decision.
>
> Signed-off-by: Jeff Garzik <jgarzik@xxxxxxxxxx>

Acked-by: Jiri Slaby <jirislaby@xxxxxxxxx>

>
> drivers/char/riscom8.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> 93ea6d56f83b7b614c103222fa098cb30d26f608
> diff --git a/drivers/char/riscom8.c b/drivers/char/riscom8.c
> index b37e626..d307320 100644
> --- a/drivers/char/riscom8.c
> +++ b/drivers/char/riscom8.c
> @@ -537,16 +537,14 @@ static inline void rc_check_modem(struct riscom_board const * bp)
> }
>
> /* The main interrupt processing routine */
> -static irqreturn_t rc_interrupt(int irq, void * dev_id)
> +static irqreturn_t rc_interrupt(int dummy, void * dev_id)
> {
> unsigned char status;
> unsigned char ack;
> - struct riscom_board *bp;
> + struct riscom_board *bp = dev_id;
> unsigned long loop = 0;
> int handled = 0;
>
> - bp = IRQ_to_board[irq];
> -

Remove the declaration of the IRQ_to_board too, since we don't reference it
anymore, we only set it up.

regards,
--
Jiri Slaby (jirislaby@xxxxxxxxx)
Faculty of Informatics, Masaryk University
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/