Re: [Git pull] arch/x86 updates

From: Thomas Gleixner
Date: Fri Oct 19 2007 - 18:19:54 EST


On Fri, 19 Oct 2007, Linus Torvalds wrote:
>>
> > Pavel Emelyanov (1):
> > i386: consolidate show_regs and show_registers for i386
>
> While I think this is good otherwise, why does it do
>
> printk(".. comm: %.*s .."
> TASK_COMM_LEN, current->comm,
>
> instead of just using "%s" and "current->comm"? I only noticed because
> there was an unrelated conflict around that thing.
>
> That "current->comm" had better be NUL-terminated already, we use it as
> such all over the place. And if it's not, *that* should be fixed.

Fair enough. Did not notice.

tglx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/