Re: [PATCH 02/10] Blackfin SPI driver: use new GPIO API and add error handling

From: David Brownell
Date: Fri Oct 19 2007 - 13:57:47 EST


> > In fact, if I look at the kernel.org GIT tree, it doesn't have
> > them either. Your tree must have somehow gotten a bunch of
> > private changes.
>
> Did you apply these patches, or I need resent a new patchset against
> latest Linus GIT tree?

I'm still not quite sure why the patches you sent didn't apply
for me. Why don't you send refreshed patches to me after RC1.


> I noticed in latest GIT tree the Blackfin SPI driver are modified.

Yes, various cleanup patches. Missing newlines in dev_*() calls,
class_device removal, remove extra includes, and so forth. They
might conflict with your patches (I suspect they won't).

That's a big part of why you should arrange to submit patches well
in advance of the merge window opening. As a rule, maintainers
won't have/make extra time during that window to review and/or fix
nontrivial issues, or address conflicts with other patches. Try to
submit at least a few weeks before the previous kernel finalizes.

- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/