fs/buffer.c:nobh_write_end(): NULL dereference

From: Adrian Bunk
Date: Fri Oct 19 2007 - 09:42:42 EST


Commit 03158cd7eb3374843de68421142ca5900df845d9 introcduced the
following NULL dereference:

<-- snip -->

...
int nobh_write_end(struct file *file, struct address_space *mapping,
loff_t pos, unsigned len, unsigned copied,
struct page *page, void *fsdata)
{
struct inode *inode = page->mapping->host;
struct buffer_head *head = NULL;
struct buffer_head *bh;

if (!PageMappedToDisk(page)) {
if (unlikely(copied < len) && !page_has_buffers(page))
attach_nobh_buffers(page, head);
... ^^^^

<-- snip -->

Spotted by the Coverity checker.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/