Re: [RFC] [PATCH -mm] ASIC3 driver

From: Thomas Gleixner
Date: Thu Oct 18 2007 - 18:16:32 EST


On Thu, 18 Oct 2007, Andrew Morton wrote:
> > +
> > +#include <linux/module.h>
> > +#include <linux/version.h>
> > +#include <linux/irq.h>
>
> Please see the large comment at the top of linux/irq.h. I believe this
> driver will fial to compile on at least arm.
>
> We really should fix this.

drivers are fine with: #include <linux/interrupt.h>

If they need linux/irq.h, then they do probably something really
nasty.

tglx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/