Re: [bug] block subsystem related crash with latest -git

From: Linus Torvalds
Date: Wed Oct 17 2007 - 14:23:34 EST




On Wed, 17 Oct 2007, Linus Torvalds wrote:
>
> So I think your change to use "sg_next()" only when you actually need a
> next pointer is the correct one after all.

That still leaves the initialization issue. The link pointers need to all
be initialized at SG allocation time (and not just the last one for the
case where it's a linked entry).

And if you initialize them at allocation time, does an allocation ever get
re-used without being free'd in between (if it does, you do indeed need to
initialize the non-link pointers each time - but I don't see it being the
case, so ..)

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/