Re: [PATCH] Map volume and brightness events on thinkpads

From: Matthew Garrett
Date: Tue Oct 16 2007 - 09:01:26 EST


On Mon, Oct 15, 2007 at 07:07:37PM -0200, Henrique de Moraes Holschuh wrote:

> And the input subsystem maintainer has made it extremely clear in various
> threads that the input devices are *not* to be used as a notification
> service for on-screen-display or other such stuff. If you send volume and
> brightness *key* events to userspace, it is supposed to act on them and
> raise/lower brightness/volume, which is the wrong thing to do on thinkpads.
> Never mind that HAL is ignoring the input maintainer's directions and
> violating this.

Reality disagrees. There are already several cases where notifications
are sent via the keyboard controller, such as the wireless and touchpad
disable keys on my HP. There are Dells that do the same for brightness
keys. Unless you want to make the argument that sending keyboard
controller events through the input layer is the wrong thing to do, it's
impossible to standardise on a setup where we never see notifications
through it.

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/