Re: RocketPort Linux driver errors on module reload

From: Wagner Ferenc
Date: Tue Oct 16 2007 - 03:47:45 EST


Jiri Slaby <jirislaby@xxxxxxxxx> writes:

> Anyway the driver faces another problem with pci refcounting (it
> doesn't increment the counter) and the device might be removed from
> it any time the pci bus code decides.

That doesn't sound too good... Do you mean the module could stop
working any time, even if its devices are being used continuously?

> Are you willing to test to-pci-probing patches (i.e. patches which
> converts the driver to the model introduced in linux 2.4)?

Well yes. We've got a copule of such cards, which raises some
interest in a proper driver. Just send the patches with some
instructions along, or point me to a git branch if you prefer.

> If not, I'll only increment the counter on modprobe and decrement it
> on rmmod, since it would be a safe (in the meaning of not changing
> that much code) way of fixing the problem.

And what are the drawbacks of this simple solution?
--
Regards,
Feri.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/