Re: Unfortunate infinite make recursion

From: Bodo Eggert
Date: Sat Sep 22 2007 - 17:19:53 EST


Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx> wrote:

> You can cause a recursion in kbuild/make with the following:
>
> make O=$PWD kernel/time.o
> make mrproper
>
> Of course no one would use O=$PWD (that's just the testcase),
> but this happened too often:
>
> /ws/linux/linux-2.6.23$ make O=/ws/linux/linux-2.6.23 kernel/time.o
> (Oops - should have been O=/ws/linux/obj-2.6.23!)
>
> The make O=$PWD truncates the Makefile, making it necessary to run `git
> checkout Makefile` - should you have git; or reextract the tarball
> (should you /still/ have it). Well, can we catch this case somehow?

You can test for the existence of MAINTAINERS in the build dir and abort
if it's there.
--
My computer isn't that nervous...it's just a bit ANSI.

Friß, Spammer: Z9asY@xxxxxxxxxxxxxxxxxxxx nwJ@xxxxxxxxxxxxxxxxxxxxxxxxxxx
l@xxxxxxxxxxxxxxxxxxxxxxxxxx pjy.jbJ@xxxxxxxxxxxxxxxxxxxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/