Re: [PATCH] [35/50] i386: Do cpuid_device_create() inCPU_UP_PREPARE instead of CPU_ONLINE.

[Thomas Gleixner]

On Sat, 2007-09-22 at 00:32 +0200, Andi Kleen wrote:
> From: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> 
> Do cpuid_device_create() in CPU_UP_PREPARE instead of CPU_ONLINE.
> 
> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> Signed-off-by: Andi Kleen <ak@xxxxxxx>
> Cc: Gautham R Shenoy <ego@xxxxxxxxxx>
> Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
>  arch/i386/kernel/cpuid.c |   32 +++++++++++++++++++-------------
>  1 file changed, 19 insertions(+), 13 deletions(-)
> 
> Index: linux/arch/i386/kernel/cpuid.c
> ===================================================================
> --- linux.orig/arch/i386/kernel/cpuid.c
> +++ linux/arch/i386/kernel/cpuid.c
> @@ -136,15 +136,18 @@ static const struct file_operations cpui
>  	.open = cpuid_open,
>  };
>  
> -static int __cpuinit cpuid_device_create(int i)
> +static int cpuid_device_create(int cpu)

	__cpuinit please

Thanks,

	tglx



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/