Re: [PATCH 07/25] r/o bind mounts: elevate write count for someioctls

From: Dave Hansen
Date: Fri Sep 21 2007 - 19:39:51 EST


On Fri, 2007-09-21 at 16:03 -0700, Andrew Morton wrote:
> Dave Hansen <haveblue@xxxxxxxxxx> wrote:
>
> > Some ioctl()s can cause writes to the filesystem. Take
> > these, and make them use mnt_want/drop_write() instead.
> >
> > We need to pass the filp one layer deeper in XFS, but
> > somebody _just_ pulled it out in February because nobody
> > was using it, so I don't feel guilty for adding it back.
>
> Note that -mm's ext2-reservations.patch adds EXT2_IOC_SETRSVSZ,
> and it doesn't do mnt_want_write().

That doesn't quite apply to mainline (at least after the patches I just
sent). I'll wait and send you one on top of the next -mm so that I can
get a coherent view of what's going on if that's all right.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/