Re: x86_64: potential critical issue with quicklists and page tablepages

[Linus Torvalds]

On Fri, 21 Sep 2007, Linus Torvalds wrote:
> 
> On Fri, 21 Sep 2007, Christoph Lameter wrote:
> > 
> > The quicklists collect pages while we gather pages for TLB flushing. 
> > These pages must be kept until the actual TLB flush has occurred. The 
> > optimization of releasing off node pages early is therefore not valid.
> 
> That should be the "mmu_gather" structure, not the quicklists.

Oh, and I see what's wrong: you not only switched "free_page()" to 
"quicklist_free()", you *also* switched "tlb_remove_page()" to 
"quicklist_free()".

Ok, that commit is totally and utterly broken. Will revert.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/