Re: x86_64: potential critical issue with quicklists and page tablepages

From: Christoph Lameter
Date: Fri Sep 21 2007 - 14:50:22 EST


On Fri, 21 Sep 2007, Linus Torvalds wrote:

> > Can we revert this commit for 2.6.23 and look at this code post 2.6.23?
>
> I'll happily revert it, but I want to understand this better, so more of
> an explanation of the codepath that actually does something wrong, please.

The quicklists collect pages while we gather pages for TLB flushing.
These pages must be kept until the actual TLB flush has occurred. The
optimization of releasing off node pages early is therefore not valid.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/