Re: [patch 3/5] VFS: pass open file to ->xattr()

[Trond Myklebust]

On Fri, 2007-09-21 at 15:16 +0200, Miklos Szeredi wrote:

> > ftruncate is a special case due to O_TRUNC.
> 
> No, it's special, because it does not do permission checking, while
> truncate() does.

So why not just add file->f_op->ftruncate() and file->f_op->fstat()?
Most filesystems can trivially redirect these to do_truncate() and their
existing getattr() method. Those, like FUSE, that care can use the hook.
In fact, I think that NFSv4 could also benefit from an ftruncate():
currently we have to hunt around for an open file context for that
particular case.

Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/