Re: [PATCH 02/03] CM-x270: ITE 8152 PCI bridge support

[Russell King - ARM Linux]

On Fri, Sep 21, 2007 at 12:42:55PM +0200, Guennadi Liakhovetski wrote:
> On Thu, 20 Sep 2007, Mike Rapoport wrote:
> 
> > This patch provides driver for ITE 8152 PCI bridge.
> > 
> > Signed-off-by: Mike Rapoport <mike@xxxxxxxxxxxxxx>
> > 
> >  arch/arm/common/Makefile          |    1 +
> >  arch/arm/common/it8152.c          |  387 +++++++++++++++++++++++++++++++++++++
> 
> Shouldn't it go to drivers/pci and define a platform driver? it8152 is not 
> an ARM specific controller.

drivers/pci is currently only used for the PCI bus infrastructure.  The
setup of host bridges is very platform dependent.

Also note that you should *avoid* DMA bounce wherever possible.
The code is broken as designed.  Ensure that the DMA mask is set
appropriately, and then moan elsewhere if things don't work.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/