Re: [PATCH 2.6.22.y, 2.6.20.y] ieee1394: ohci1394: fix initialization if built non-modular

From: Willy Tarreau
Date: Fri Sep 21 2007 - 02:16:53 EST


On Fri, Sep 21, 2007 at 08:11:08AM +0200, Stefan Richter wrote:
> Initialization of ohci1394 was broken according to one reporter if the
> driver was statically linked, i.e. not built as loadable module. Dmesg:
>
> PCI: Device 0000:02:07.0 not available because of resource collisions
> ohci1394: Failed to enable OHCI hardware.
>
> This was reported for a Toshiba Satellite 5100-503. The cause is commit
> 8df4083c5291b3647e0381d3c69ab2196f5dd3b7 in Linux 2.6.19-rc1 which only
> served purposes of early remote debugging via FireWire. This
> functionality is better provided by the currently out-of-tree driver
> ohci1394_earlyinit. Reversal of the commit was OK'd by Andi Kleen.
>
> Same as pre-2.6.23 commit be7963b7e7f08a149e247c0bf29a4abd174e0929.
>
> Signed-off-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx>
> ---

thanks Stefan. I still have a few fixes pending for 2.6.20, I'll release
another one soon including your patch.

regards,
willy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/