Re: [PATCH 03/24] create cleanup helper svc_msnfs()

From: Trond Myklebust
Date: Wed Sep 19 2007 - 14:11:10 EST


On Wed, 2007-09-19 at 18:59 +0100, Christoph Hellwig wrote:
> On Wed, Sep 19, 2007 at 01:54:06PM -0400, Trond Myklebust wrote:
> > > If it were some kind of larger API, we could come up with something
> > > better. But, for a single isolated user, I think it is OK.
> >
> > The msnfs option means enable the use of MS Windows share locks, so yes,
> > the name is appropriate.
>
> Yepp. While we're at it, can we please kill the silly ifdefs for it
> (once Dave's patches are merged to avoid conflicts). The code has always
> been enabled since it was introduced, it's an export option anyway and
> to make things worse the ifdef needs to be disabled in multiple files
> to make it consistant..

I'm sure that either Neil or Bruce would be happy to take such a patch.

Cheers
Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/