[PATCH] ucb1400_ts.c -- replace an interruptible sleep with an uninterruptibleone

From: Rene Herman
Date: Tue Sep 18 2007 - 10:54:45 EST


Hi Nicolas.

Given that it's not checking for signals, I believe this one should be an uninterruptible sleep instead?

Signed-off-by: Rene Herman <rene.herman@xxxxxxxxx>

Rene. diff --git a/drivers/input/touchscreen/ucb1400_ts.c b/drivers/input/touchscreen/ucb1400_ts.c
index f0cbcdb..670dd49 100644
--- a/drivers/input/touchscreen/ucb1400_ts.c
+++ b/drivers/input/touchscreen/ucb1400_ts.c
@@ -130,8 +130,7 @@ static unsigned int ucb1400_adc_read(struct ucb1400 *ucb, u16 adc_channel)
if (val & UCB_ADC_DAT_VALID)
break;
/* yield to other processes */
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(1);
+ schedule_timeout_uninterruptible(1);
}

return UCB_ADC_DAT_VALUE(val);