Re: [PATCH] Add a refcount check in dput()

From: Paul Menage
Date: Mon Sep 17 2007 - 14:21:54 EST


On 9/15/07, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > + BUG_ON(!atomic_read(&dentry->d_count));
> > repeat:
> > if (atomic_read(&dentry->d_count) == 1)
> > might_sleep();
>
> eek, much too aggressive.

How about the equivalent BUG_ON() in dget()? I figure that they ought
to both be of the same strictness.

Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/