Re: [PATCH] drivers/firmware: const-ify DMI API and internals

From: Bartlomiej Zolnierkiewicz
Date: Tue Sep 11 2007 - 17:53:40 EST


On Saturday 01 September 2007, Jeff Garzik wrote:
>
> commit 457b6eb3bf3341d2e143518a0bb99ffbb8d754c4
> Author: Jeff Garzik <jeff@xxxxxxxxxx>
> Date: Sat Sep 1 10:16:45 2007 -0400
>
> drivers/firmware: const-ify DMI API and internals
>
> Three main sets of changes:
>
> 1) dmi_get_system_info() return value should have been marked const,
> since callers should not be changing that data.
>
> 2) const-ify DMI internals, since DMI firmware tables should,
> whenever possible, be marked const to ensure we never ever write to
> that data area.
>
> 3) const-ify DMI API, to enable marking tables const where possible
> in low-level drivers.
>
> And if we're really lucky, this might enable some additional
> optimizations on the part of the compiler.
>
> The bulk of the changes are #2 and #3, which are interrelated. #1 could
> have been a separate patch, but it was so small compared to the others,
> it was easier to roll it into this changeset.
>
> Signed-off-by: Jeff Garzik <jeff@xxxxxxxxxx>

[ a bit late ]

Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/