Re: [PATCH -mm][resend] softlockup-improve-debug-output.patch fix

[Ingo Molnar]

* Satyam Sharma <satyam@xxxxxxxxxxxxx> wrote:

> 
> 
> On Sun, 2 Sep 2007, Satyam Sharma wrote:
> > 
> > --- kernel/softlockup.c~fix	2007-09-02 04:23:49.000000000 +0530
> > +++ kernel/softlockup.c	2007-09-02 04:34:45.000000000 +0530
>   ^^^^^^^^^^
> 
> Ick, I botched a trivial patch, it doesn't even apply. Updated one below
> (with indentation fix as added bonus :-)
> 
> 
> [PATCH -mm] softlockup-improve-debug-output.patch fix (v2)
> 
> kernel/softlockup.c: In function 'softlockup_tick':
> kernel/softlockup.c:125: warning: 'regs' is used uninitialized in this function
> 
> is a genuine bug (will cause an oops in all probability, or cause 
> wrong info to be printed, if we're lucky). So let's fix the 
> softlockup-improve-debug-output.patch to actually work as intended.
> 
> Signed-off-by: Satyam Sharma <satyam@xxxxxxxxxxxxx>

Thanks! Not sure how that bug slipped in, in my tree it does this:

 +       struct pt_regs *regs;
 ...
 +       regs = get_irq_regs();

Acked-by: Ingo Molnar <mingo@xxxxxxx>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/