Re: [PATCH] make kobject dynamic allocation check usekallsyms_lookup()

From: Satyam Sharma
Date: Thu Aug 23 2007 - 01:06:15 EST


Hi Dave,


On Wed, 22 Aug 2007, Dave Hansen wrote:
>
> One of the top ten sysfs problems is that users use statically
> allocated kobjects. This patch reminds them that this is a
> naughty thing.

Hmm, I might've missed previous discussion regarding this, but I'm
curious to know why using statically allocated kobjects is "naughty".
The code / warnings / printk messages below indicate this is only a
"silly/janitorial" issue?

The reason I ask is that if it is serious, there is no reason why this
check cannot be done at build-time itself, instead of this runtime
kludge in the kernel -- catching potential bugs at build-time is always
desirable. Modpost or some such tool can be taught to detect kobjects
allocated statically in vmlinux/modules -- or there can be other build-
time solutions, possibly. Have you considered such an approach?


Thanks,

Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/