Re: 2.6.23-rc3-mm1

From: Andrew Morton
Date: Wed Aug 22 2007 - 14:14:54 EST


On Wed, 22 Aug 2007 19:24:39 +0200
"Torsten Kaiser" <just.for.lkml@xxxxxxxxxxxxxx> wrote:

> On 8/22/07, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc3/2.6.23-rc3-mm1/
> [snip]
> > -ata-add-the-sw-ncq-support-to-sata_nv-for-mcp51-mcp55-mcp61.patch
> > -ata-add-the-sw-ncq-support-to-sata_nv-for-mcp51-mcp55-mcp61-fix.patch
> [snip]
> > Merged into mainline or a subsystem tree
>
> That patch is no longer in 2.6.23-rc3-mm1, my bootlog says:
> [ 0.000000] Unknown boot option `sata_nv.swncq=1': ignoring
>
> I could not find this patch in any git trees I looked and its removal
> mail from mm-commit said:
> "This patch was dropped because Changes in Jeff's tree destroyed it."
>
>
> I only found out about the swncq=1 command line option yesterday and
> so tested it only one day.
> But I did not have any trouble with it, even as my drive was made by Maxtor.
>
> The chipset:
> 00:05.0 IDE interface: nVidia Corporation MCP55 SATA Controller (rev a3)
> 00:05.1 IDE interface: nVidia Corporation MCP55 SATA Controller (rev a3)
> 00:05.2 IDE interface: nVidia Corporation MCP55 SATA Controller (rev a3)
>
> The drive:
> Device Model: MAXTOR STM3320820AS
> Serial Number: 5QF2E698
> Firmware Version: 3.AAE
>
> As it worked for me, I hope that patch will be picked up by someone. :)
>

This is a fairly regular occurrence in ata land: patches from maintainers
don't get merged, so I merge them for testing, then some fairly pointless
cleanup-style patch goes on a great tree-wide rampage thus destabilising or
simply destroying the more important, mysteriously-not-merged patch.

Nobody knows why this happens.

Peer and Kuan: can you please redo that patch against the current ata
development tree?

Thanks.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/