Re: [RFC 5/7] Laundry handling for direct reclaim

[Christoph Lameter]

On Tue, 21 Aug 2007, Mel Gorman wrote:

> > +		nr_reclaimed += shrink_zones(priority, zones, &sc, &laundry);
> >  		shrink_slab(sc.nr_scanned, gfp_mask, lru_pages);
> >  		if (reclaim_state) {
> >  			nr_reclaimed += reclaim_state->reclaimed_slab;
> >  			reclaim_state->reclaimed_slab = 0;
> >  		}
> > +
> >  		total_scanned += sc.nr_scanned;
> > +
> 
> Could this not isolate a load of dirty pages on the laundry list and then
> shortly later go to sleep in congestion_wait() ? It would appear that with
> writeout deferred that the going to sleep is going to do nothing to help
> the situation.

Yep that seems to be the problem that Peter saw. We need to throttle 
later.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/