Re: SLUB bug on sparc64

From: David Miller
Date: Mon Aug 20 2007 - 19:01:59 EST


From: Christoph Lameter <clameter@xxxxxxx>
Date: Mon, 20 Aug 2007 11:34:52 -0700 (PDT)

> On Fri, 17 Aug 2007, David Miller wrote:
>
> > When I force SLUB debugging on sparc64, it barfs on early bootup while
> > making the sysfs nodes. Removing the BUG()'s on the sysfs error
> > returns, and adding some tracing I captured the log below.
> >
> > BTW, I would recommending removing the BUG() calls, they serve only to
> > force someone hitting them to edit them out and reboot which is
> > absolutely pointless :-) This code can also often run before the
> > console is first enabled, making analysis of the error return that
> > much harder if it BUG()'s instead of trying to continue.
>
> Not sure what BUG's you are talking about.

The two BUG_ON()'s on "err" as returned from sysfs_slab_alias()
and sysfs_slab_add().

> Does this patch fix it?

Yep, it does, thanks a lot!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/