Re: [PATCH 4/5] Documentation/firmware/... convert #include"linux/..." to #include <linux/...>

From: Randy Dunlap
Date: Sun Aug 19 2007 - 18:28:39 EST


On Sun, 19 Aug 2007 15:19:32 -0700 Joe Perches wrote:

> (untested)
>
> There are several files that
> #include "linux/file" not #include <linux/file>
> #include "asm/file" not #include <asm/file>
>
> Here's a little script that converts them:
>
> egrep -i -r -l --include=*.[ch] \
> "^[[:space:]]*\#[[:space:]]*include[[:space:]]*\"(linux|asm)/(.*)\"" * \
> | xargs sed -i -e 's/^[[:space:]]*#[[:space:]]*include[[:space:]]*"\(linux\|asm\)\/\(.*\)"/#include <\1\/\2>/g'
>
> This one is probably wrong.
>
> It should likely keep firmware.h in
> the same directory as firmware.c
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
>
> diff --git a/Documentation/firmware_class/firmware_sample_driver.c b/Documentation/firmware_class/firmware_sample_driver.c
> index 6865cbe..754ded2 100644
> --- a/Documentation/firmware_class/firmware_sample_driver.c
> +++ b/Documentation/firmware_class/firmware_sample_driver.c
> @@ -13,7 +13,7 @@
> #include <linux/device.h>
> #include <linux/string.h>
>
> -#include "linux/firmware.h"
> +#include "firmware.h"

I believe that it should be <linux/firmware.h>.

> static struct device ghost_device = {
> .bus_id = "ghost0",


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/