Re: kfree(0) - ok?

From: Christoph Lameter
Date: Fri Aug 17 2007 - 17:14:27 EST


On Sat, 18 Aug 2007, Satyam Sharma wrote:

> > page = get_object_page(object);
>
> Hmm, I didn't know ksize(NULL) was also allowed to succeed (and
> return 0).

That was merged over my objections. IMHO ksize(NULL) should fail since we
are determining the size of an unallocated object.

> Oh yes, of course. We want krealloc(NULL) cases to behave consistently
> as expected, and letting ksize(NULL) return 0 means the code for
> krealloc() can lose an extra "if (!p)" check that would otherwise have
> been required. Cool.

krealloc should check for that.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/