Re: [draft] Blackfin Early Printk implmentation

[Mike Frysinger]

On 8/17/07, Robin Getz <rgetz@xxxxxxxxxxxxxxxxxxxx> wrote:
> +       asm("\tRETI = %0;\n"
> +           "\tRETX = %0;\n"
> +           "\tRETN = %0;\n"
> +           : : "p"(early_trap));

general note, i dont think inserting whitespace by hand in asm() is a
good thing ... i see it as whitenoise personally ...

> +int __init disable_early_printk(void)
> +{
> +       if (!early_console_initialized)
> +               return 0;
> +
> +       printk(KERN_INFO "Unregister %s%d\n", early_console_initialized->name,
> +               early_console_initialized->index);
> +       unregister_console(early_console_initialized);
> +       early_console_initialized = NULL;
> +       return 0;
> +}
> +
> +late_initcall(disable_early_printk);

i think we agreed this would be OK/good to have in common code
-mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/