Re: [PATCH 000 of 5] Introductory patches for bio refactor.

From: Jens Axboe
Date: Thu Aug 16 2007 - 02:37:40 EST


On Thu, Aug 16 2007, NeilBrown wrote:
>
> Hi Jens,
> I wonder if you would accept these patches the block layer.
> They are, as far as I can tell, quite uncontroversial and provide
> good cleanups.
>
> The first is a minor bug-fix.
> The next to replace helper function that take a bio (always the first
> bio of a request), to instead take a request.
>
> The last two combine to replace rq_for_each_bio with
> rq_for_each_segment which makes blk_recalc_rq_segments a lot
> cleaner, and improves (to a lesser degree) every other place that
> used rq_for_each_bio.
>
> The net result is a decrease in object code size (for my x86-64 compile)
> for block/built-in.o of 96 bytes, though there is some growth out in
> drivers making and over-all decrease of only 48 bytes.

Thanks for seperating these out Neil, will go over them this morning!

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/